card.js ➔ payWithStripe - Code Metrics - Inspection of "Added assets, views + config. Created controller,..." - conferencetools/checkin-module - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 645913...ffdc3b )

by Chris

created 2018-02-07 08:43 UTC

card.js ➔ payWithStripe A

↳ Parent: assets/js/card.js

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	54
rs	9.6716

1 Function

Rating	Name	Duplication	Size	Complexity
A	card.js ➔ ... ➔ stripeResponseHandler	0	20	2

How to fix Long Method

/*
 The MIT License (MIT)

 Copyright (c) 2015 William Hilton

 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:

 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.

 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 */
var $form = $('#payment-form');
var submitPaymentButton = $('#submit-payment');
var delegateForm = $('#delegate-form');
var stripeTokenElement = delegateForm.find('input[name="stripe_token"]');
submitPaymentButton.on('click', payWithStripe);

/* If you're using Stripe for payments */
function payWithStripe(e) {

    e.preventDefault();
    function stripeResponseHandler(status, response) {
        if (response.error) {
            /* Visual feedback */
            submitPaymentButton.html('Try again').prop('disabled', false);
            /* Show Stripe errors on the form */
            $form.find('.payment-errors').text(response.error.message);
            $form.find('.payment-errors').closest('.row').show();
        } else {
            /* Visual feedback */
            submitPaymentButton.html('Processing <i class="fa fa-spinner fa-pulse"></i>');
            /* Hide Stripe errors on the form */
            $form.find('.payment-errors').closest('.row').hide();
            $form.find('.payment-errors').text("");
            // response contains id and card, which contains additional card details

            var token = response.id;
            stripeTokenElement.val(token);
            delegateForm.submit();
        }
    }

    if (stripeTokenElement.val() != '') {
        delegateForm.submit();
    }

    /* Abort if invalid form data */
    if (!validator.form()) {

        return;
    }

    /* Visual feedback */
    $('#submit-payment').html('Validating <i class="fa fa-spinner fa-pulse"></i>').prop('disabled', true).removeClass('btn-success');

    /* Create token */
    var expiry = $form.find('[name=cardExpiry]').payment('cardExpiryVal');
    var ccData = {
        number: $form.find('[name=cardNumber]').val().replace(/\s/g,''),
        cvc: $form.find('[name=cardCVC]').val(),
        exp_month: expiry.month,
        exp_year: expiry.year,
        name: $form.find('[name=cardName]').val(),
        address_line1: $form.find('[name=cardLine1]').val(),
        address_line2: $form.find('[name=cardLine2]').val(),
        address_city: $form.find('[name=cardCity]').val(),
        address_state: $form.find('[name=cardState]').val(),
        address_zip: $form.find('[name=cardZip]').val(),
        address_country: $form.find('[name=cardCountry]').val()
    };

    Stripe.card.createToken(ccData, stripeResponseHandler);

}
/* Fancy restrictive input formatting via jQuery.payment library*/
$('input[name=cardNumber]').payment('formatCardNumber');
$('input[name=cardCVC]').payment('formatCardCVC');
$('input[name=cardExpiry]').payment('formatCardExpiry');

/* Form validation using Stripe client-side validation helpers */
jQuery.validator.addMethod("cardNumber", function(value, element) {
    return this.optional(element) || Stripe.card.validateCardNumber(value);

}, "Please specify a valid credit card number.");

jQuery.validator.addMethod("cardExpiry", function(value, element) {
    /* Parsing month/year uses jQuery.payment library */
    value = $.payment.cardExpiryVal(value);
    return this.optional(element) || Stripe.card.validateExpiry(value.month, value.year);

}, "Invalid expiration date.");

jQuery.validator.addMethod("cardCVC", function(value, element) {
    return this.optional(element) || Stripe.card.validateCVC(value);

}, "Invalid CVC.");

validator = $form.validate({

    rules: {
        cardNumber: {
            required: true,
            cardNumber: true
        },
        cardExpiry: {
            required: true,
            cardExpiry: true
        },
        cardCVC: {
            required: true,
            cardCVC: true
        }
    },
    highlight: function(element) {
        $(element).closest('.form-control').removeClass('success').addClass('error');
    },
    unhighlight: function(element) {
        $(element).closest('.form-control').removeClass('error').addClass('success');
    },
    errorPlacement: function(error, element) {
        $(element).closest('.form-group').append(error);
    }
});

paymentFormReady = function() {

    return ($form.find('[name=cardNumber]').hasClass("success") &&
        $form.find('[name=cardExpiry]').hasClass("success") &&
        $form.find('[name=cardCVC]').val().length > 1);
};

submitPaymentButton.prop('disabled', true);
var readyInterval = setInterval(function() {
    if (paymentFormReady() || stripeTokenElement.val() != '') {
        submitPaymentButton.prop('disabled', false).addClass('btn-success');
        clearInterval(readyInterval);
    }
}, 250);

1			/*
2			The MIT License (MIT)
3
4			Copyright (c) 2015 William Hilton
5
6			Permission is hereby granted, free of charge, to any person obtaining a copy
7			of this software and associated documentation files (the "Software"), to deal
8			in the Software without restriction, including without limitation the rights
9			to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10			copies of the Software, and to permit persons to whom the Software is
11			furnished to do so, subject to the following conditions:
12
13			The above copyright notice and this permission notice shall be included in
14			all copies or substantial portions of the Software.
15
16			THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17			IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18			FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19			AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20			LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21			OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
22			THE SOFTWARE.
23			*/
24			var $form = $('#payment-form');
25			var submitPaymentButton = $('#submit-payment');
26			var delegateForm = $('#delegate-form');
27			var stripeTokenElement = delegateForm.find('input[name="stripe_token"]');
28			submitPaymentButton.on('click', payWithStripe);
29
30			/* If you're using Stripe for payments */
31			function payWithStripe(e) {
32
33			e.preventDefault();
34			function stripeResponseHandler(status, response) {
35			if (response.error) {
36			/* Visual feedback */
37			submitPaymentButton.html('Try again').prop('disabled', false);
38			/* Show Stripe errors on the form */
39			$form.find('.payment-errors').text(response.error.message);
40			$form.find('.payment-errors').closest('.row').show();
41			} else {
42			/* Visual feedback */
43			submitPaymentButton.html('Processing <i class="fa fa-spinner fa-pulse"></i>');
44			/* Hide Stripe errors on the form */
45			$form.find('.payment-errors').closest('.row').hide();
46			$form.find('.payment-errors').text("");
47			// response contains id and card, which contains additional card details
48
49			var token = response.id;
50			stripeTokenElement.val(token);
51			delegateForm.submit();
52			}
53			}
54
55			if (stripeTokenElement.val() != '') {
56			delegateForm.submit();
57			}
58
59			/* Abort if invalid form data */
60			if (!validator.form()) {
			0 ignored issues – show Bug introduced 2018-02-07 08:47 UTC by Report Bug Copy Issue Report The variable `validator` seems to be never declared. If this is a global, consider adding a `/** global: validator */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
61			return;
62			}
63
64			/* Visual feedback */
65			$('#submit-payment').html('Validating <i class="fa fa-spinner fa-pulse"></i>').prop('disabled', true).removeClass('btn-success');
66
67			/* Create token */
68			var expiry = $form.find('[name=cardExpiry]').payment('cardExpiryVal');
69			var ccData = {
70			number: $form.find('[name=cardNumber]').val().replace(/\s/g,''),
71			cvc: $form.find('[name=cardCVC]').val(),
72			exp_month: expiry.month,
73			exp_year: expiry.year,
74			name: $form.find('[name=cardName]').val(),
75			address_line1: $form.find('[name=cardLine1]').val(),
76			address_line2: $form.find('[name=cardLine2]').val(),
77			address_city: $form.find('[name=cardCity]').val(),
78			address_state: $form.find('[name=cardState]').val(),
79			address_zip: $form.find('[name=cardZip]').val(),
80			address_country: $form.find('[name=cardCountry]').val()
81			};
82
83			Stripe.card.createToken(ccData, stripeResponseHandler);
			0 ignored issues – show Bug introduced 2018-02-07 08:47 UTC by Report Bug Copy Issue Report The variable `Stripe` seems to be never declared. If this is a global, consider adding a `/** global: Stripe */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
84			}
85			/* Fancy restrictive input formatting via jQuery.payment library*/
86			$('input[name=cardNumber]').payment('formatCardNumber');
87			$('input[name=cardCVC]').payment('formatCardCVC');
88			$('input[name=cardExpiry]').payment('formatCardExpiry');
89
90			/* Form validation using Stripe client-side validation helpers */
91			jQuery.validator.addMethod("cardNumber", function(value, element) {
92			return this.optional(element) \|\| Stripe.card.validateCardNumber(value);
			0 ignored issues – show Bug introduced 2018-02-07 08:47 UTC by Report Bug Copy Issue Report The variable `Stripe` seems to be never declared. If this is a global, consider adding a `/** global: Stripe */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
93			}, "Please specify a valid credit card number.");
94
95			jQuery.validator.addMethod("cardExpiry", function(value, element) {
96			/* Parsing month/year uses jQuery.payment library */
97			value = $.payment.cardExpiryVal(value);
98			return this.optional(element) \|\| Stripe.card.validateExpiry(value.month, value.year);
			0 ignored issues – show Bug introduced 2018-02-07 08:47 UTC by Report Bug Copy Issue Report The variable `Stripe` seems to be never declared. If this is a global, consider adding a `/** global: Stripe */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
99			}, "Invalid expiration date.");
100
101			jQuery.validator.addMethod("cardCVC", function(value, element) {
102			return this.optional(element) \|\| Stripe.card.validateCVC(value);
			0 ignored issues – show Bug introduced 2018-02-07 08:47 UTC by Report Bug Copy Issue Report The variable `Stripe` seems to be never declared. If this is a global, consider adding a `/** global: Stripe */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
103			}, "Invalid CVC.");
104
105			validator = $form.validate({
			0 ignored issues – show Bug introduced 2018-02-07 08:47 UTC by Report Bug Copy Issue Report The variable `validator` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.validator`. Loading history...
106			rules: {
107			cardNumber: {
108			required: true,
109			cardNumber: true
110			},
111			cardExpiry: {
112			required: true,
113			cardExpiry: true
114			},
115			cardCVC: {
116			required: true,
117			cardCVC: true
118			}
119			},
120			highlight: function(element) {
121			$(element).closest('.form-control').removeClass('success').addClass('error');
122			},
123			unhighlight: function(element) {
124			$(element).closest('.form-control').removeClass('error').addClass('success');
125			},
126			errorPlacement: function(error, element) {
127			$(element).closest('.form-group').append(error);
128			}
129			});
130
131			paymentFormReady = function() {
			0 ignored issues – show Bug introduced 2018-02-07 08:47 UTC by Report Bug Copy Issue Report The variable `paymentFormReady` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.paymentFormReady`. Loading history...
132			return ($form.find('[name=cardNumber]').hasClass("success") &&
133			$form.find('[name=cardExpiry]').hasClass("success") &&
134			$form.find('[name=cardCVC]').val().length > 1);
135			};
136
137			submitPaymentButton.prop('disabled', true);
138			var readyInterval = setInterval(function() {
139			if (paymentFormReady() \|\| stripeTokenElement.val() != '') {
140			submitPaymentButton.prop('disabled', false).addClass('btn-success');
141			clearInterval(readyInterval);
142			}
143			}, 250);

conferencetools / checkin-module

Push — master ( 645913...ffdc3b )

card.js ➔ payWithStripe A

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like